Re: scr_*() audit

From: Olaf Hering (olh@suse.de)
Date: Fri Aug 24 2001 - 06:06:14 EST


On Thu, Aug 23, Olaf Hering wrote:

> On Wed, Aug 22, Geert Uytterhoeven wrote:
>
> > + q++
>
> typo :)
>
> > diff -ur linux-2.4.8-ac9/drivers/video/hgafb.c scr-audit-2.4.8-ac9/drivers/video/hgafb.c
> > --- linux-2.4.8-ac9/drivers/video/hgafb.c Mon May 28 11:07:02 2001
> > +++ scr-audit-2.4.8-ac9/drivers/video/hgafb.c Wed Aug 22 18:48:32 2001
> > @@ -203,7 +203,7 @@
> > fillchar = 0x00;
> > spin_unlock_irqrestore(&hga_reg_lock, flags);
> > if (fillchar != 0xbf)
> > - memset((char *)hga_vram_base, fillchar, hga_vram_len);
> > + isa_memset_io((char *)hga_vram_base, fillchar, hga_vram_len);
> > }
> >
> >
> > @@ -279,7 +279,8 @@
> > char *logo = linux_logo_bw;
> > for (y = 134; y < 134 + 80 ; y++) /* this needs some cleanup */
> > for (x = 0; x < 10 ; x++)
> > - *(dest + (y%4)*8192 + (y>>2)*90 + x + 40) = ~*(logo++);
> > + isa_writeb(~*(logo++),
> > + (dest + (y%4)*8192 + (y>>2)*90 + x + 40));
> > }

--- hgafb.c Thu Aug 23 23:19:58 2001
+++ drivers/video/hgafb.c Fri Aug 24 13:02:57 2001
@@ -203,7 +203,7 @@
                fillchar = 0x00;
        spin_unlock_irqrestore(&hga_reg_lock, flags);
        if (fillchar != 0xbf)
- isa_memset_io((char *)hga_vram_base, fillchar, hga_vram_len);
+ isa_memset_io(hga_vram_base, fillchar, hga_vram_len);
 }

@@ -280,7 +280,7 @@
        for (y = 134; y < 134 + 80 ; y++) /* this needs some cleanup */
                for (x = 0; x < 10 ; x++)
                        isa_writeb(~*(logo++),
- (dest + (y%4)*8192 + (y>>2)*90 + x + 40));
+ *(dest + (y%4)*8192 + (y>>2)*90 + x + 40));
 }
 #endif /* MODULE */

Anyone with a hercules card around? Do they still work?

Gruss Olaf

-- 
 $ man clone

BUGS Main feature not yet implemented... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Aug 31 2001 - 21:00:08 EST