Re: Filling holes in ext2

From: Adrian Cox (adrian@humboldt.co.uk)
Date: Thu Aug 23 2001 - 16:21:20 EST


Andrew Morton wrote:
> Ah. Now I'm with you. Yes, we need a better cleanup facility
> to handle this.
>
> We can sort-of fudge it with commit_write():
[snip]
> Which is OK for mid-file blocks, but will cause i_size to be extended
> at eof, which probably isn't too bad. Needs more thought.

That certainly stops it happening. Does anybody think that extending
i_size in this particular corner case is harmful?

As Alan said, the bug is the file system committing metadata too early,
and I suspect that ext2 is not the only culprit.

-- 
Adrian Cox   http://www.humboldt.co.uk/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 23 2001 - 21:01:02 EST