Re: [Patch] sysinfo compatibility

From: Christoph Rohland (cr@sap.com)
Date: Wed Aug 22 2001 - 11:04:37 EST


Hi Erik,

On Wed, 22 Aug 2001, Erik Andersen wrote:
> On Wed Aug 22, 2001 at 08:44:39AM +0200, Christoph Rohland wrote:
>>
>> BTW I appreciate the basics of the change for 2.4, but I don't
>> agree that we should break cases which worked before. (And the
>> comment in the sources is plain wrong that 2.2 failed in these
>> cases)
>
> But 2.2 _did_ fail. If you take a linux 2.2.x system, add 4 Gigs of
> swap, and then use sysinfo(), the sizes you get back are junk...

But if you add 3.9GB it is ok. Also with 3.9GB RAM. And that's a quite
common machine in our environment.

If one of these overflows I agree that the 2.4 scheme is better. But
we should keep compatibility as long as we have no single field which
overflows.

And that's what my patch implements.

Greetings
                Christoph

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 23 2001 - 21:00:49 EST