On Tue, 21 Aug 2001, Daniel Phillips wrote:
> On August 20, 2001 11:50 pm, Marcelo Tosatti wrote:
> > On Tue, 21 Aug 2001, Daniel Phillips wrote:
>
> > > If you've seen streaming IO pages getting evicted before being used,
> > > I'd like to know about it because something is broken in that case.
> >
> > I've seen the first page read by "swapin_readahead()" (which is the actual
> > page we want to swapin) be evicted _before_ we could actually use it (so
> > the read_swap_cache_async() call had to read the same page _again_ from
> > disk).
>
> It's not streaming IO, but whoops,
It does not matter. It just tells you that you're dropping pages too
early. That is even more valid for streaming IO.
I understand that having readahead pages to apply too much pressure
on really used pages is bad.
However, considering readaheaded pages as a "special case" (and drop them
previously, or whatever) will _always_ potentially fuckup streaming IO (so
yes, I think the old drop behind code is bad too).
> is that even with yesterday's SetPageReferenced patch to do_swap_page?
No. It will not help: the call to read_swap_cache_async() is before the
SetPageReferenced call.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Aug 23 2001 - 21:00:38 EST