[PATCH] small SCSI use count fix

From: Tim Hockin (thockin@sun.com)
Date: Mon Aug 13 2001 - 23:43:18 EST

Next message: Jordan: "Trouble rebooting/halting SMP box with 2.4.x"
Previous message: Alexander Viro: "Re: [PATCH] (1/11) fs/super.c fixes"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Attached is a small fix to increment the use count in scsi_register_host()
before we start working with it - prevent false decrementing. (from one of
the crew here ;)

Please let me know if there is any reason this shouldn't go mainline in the
next 2.4.x.

thanks
Tim

-- 
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com

diff -ruN dist+patches-2.4.8/drivers/scsi/scsi.c cobalt-2.4.8/drivers/scsi/scsi.c --- dist+patches-2.4.8/drivers/scsi/scsi.c Thu Jul 19 21:07:04 2001 +++ cobalt-2.4.8/drivers/scsi/scsi.c Mon Aug 13 16:42:24 2001 @@ -1835,6 +1828,8 @@ pcount = next_scsi_host; + MOD_INC_USE_COUNT; + /* The detect routine must carefully spinunlock/spinlock if it enables interrupts, since all interrupt handlers do spinlock as well. @@ -1964,8 +1965,6 @@ (scsi_init_memory_start - scsi_memory_lower_value) / 1024, (scsi_memory_upper_value - scsi_init_memory_start) / 1024); #endif - - MOD_INC_USE_COUNT; if (out_of_space) { scsi_unregister_host(tpnt); /* easiest way to clean up?? */

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Jordan: "Trouble rebooting/halting SMP box with 2.4.x"
Previous message: Alexander Viro: "Re: [PATCH] (1/11) fs/super.c fixes"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Aug 15 2001 - 21:00:50 EST