2.4.8 breaks ATM

From: Renaud Guérin (rguerin@free.fr)
Date: Sun Aug 12 2001 - 07:43:47 EST

Next message: Maciej Zenczykowski: "Re: VM nuisance"
Previous message: Alan Cox: "Re: Hang problem on Tyan K7 Thunder resolved -- SB Live! heads-up"
Next in thread: Mitchell Blank Jr: "Re: 2.4.8 breaks ATM"
Reply: Mitchell Blank Jr: "Re: 2.4.8 breaks ATM"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

The following part of the 2.4.8 patch seems to be a typo (">>" looks more
logical than ">" if vci_bit is a bitfield), and broke ATM for me:

--- v2.4.7/linux/net/atm/common.c Tue Jul 3 17:08:22 2001
+++ linux/net/atm/common.c Sun Aug 5 13:12:41 2001
@@ -210,7 +210,7 @@

        if ((vpi != ATM_VPI_UNSPEC && vpi != ATM_VPI_ANY &&
            vpi >> dev->ci_range.vpi_bits) || (vci != ATM_VCI_UNSPEC &&
- vci != ATM_VCI_ANY && vci >> dev->ci_range.vci_bits))
+ vci != ATM_VCI_ANY && vci > dev->ci_range.vci_bits))
                return -EINVAL;
        if (vci > 0 && vci < ATM_NOT_RSV_VCI &&
!capable(CAP_NET_BIND_SERVICE))
                return -EPERM;

I simply reverted the patch and it works again.

-- 
-----------------------------------------------
Renaud Guerin
rguerin@free.fr - guerinre@utt.fr
Génie des Systèmes d'Information et de Décision
Université de Technologie de Troyes (France)
-----------------------------------------------
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Maciej Zenczykowski: "Re: VM nuisance"
Previous message: Alan Cox: "Re: Hang problem on Tyan K7 Thunder resolved -- SB Live! heads-up"
Next in thread: Mitchell Blank Jr: "Re: 2.4.8 breaks ATM"
Reply: Mitchell Blank Jr: "Re: 2.4.8 breaks ATM"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Aug 15 2001 - 21:00:41 EST