Re: Linux 2.4.7-ac9 (breaks ATM connect)

From: David S. Miller (davem@redhat.com)
Date: Thu Aug 09 2001 - 15:30:14 EST


Sampsa Ranta writes:
> Pardon me, bugs come in too easy..
>
> - vci != ATM_VCI_ANY && vci >> dev->ci_range.vci_bits))
> + vci != ATM_VCI_ANY && vci >= 1 << dev->ci_range.vci_bits))
>

This is rediculious, why has this expression changed when right
above it is the same thing:

          vpi >> dev->ci_range.vpi_bits) || (vci != ATM_VCI_UNSPEC &&

Shouldn't we be changing that "vpi >> dev->ci_range.vpi_bits" boolean
test as well?

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Aug 15 2001 - 21:00:29 EST