Re: BUG: Assertion failure with ext3-0.95 for 2.4.7

From: Andrew Morton (akpm@zip.com.au)
Date: Thu Aug 09 2001 - 13:58:46 EST


Christian Borntraeger wrote:
>
> Hello ext3-users,
>
> I tested ext3 on a Linux for S/390 with several stress and benchmark test
> tests and faced a kernel bug message.
> The console showed the following output:
>
> Message from syslogd@boeaet34 at Fri Aug 3 11:34:16 2001 ...
> boeaet34 kernel: Assertion failure in journal_forget() at
> transaction.c:1184: "!
> jh->b_committed_data"
>

Simple bug, subtle symptoms. Could you please retest 0.9.5
with this patch? Thanks.

--- ext3-0_9_5/fs/ext3/inode.c Mon Jul 30 05:46:12 2001
+++ ext3/fs/ext3/inode.c Thu Aug 9 00:03:34 2001
@@ -1522,7 +1523,7 @@
          * AKPM: turn on bforget in journal_forget()!!!
          */
         for (p = first; p < last; p++) {
- u32 nr = *p;
+ u32 nr = le32_to_cpu(*p);
                 if (nr) {
                         struct buffer_head *bh;
 

Now, if all on-disk structures were defined in terms of something
like

        struct disk32 {
                u32 x;
        }

then these things wold never happen - the compiler would catch
it.

-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Aug 15 2001 - 21:00:28 EST