Re: symlink_prefix

From: Andries.Brouwer@cwi.nl
Date: Sun Jun 03 2001 - 10:10:53 EST


    From viro@math.psu.edu Sun Jun 3 13:25:31 2001

> [One could start a subdiscussion about that part.
> The mount(2) system call needs to transport vfs information
> and per-fs information. So far, the vfs information used
> flag bits only, but sooner or later we'll want to have
> strings, and need a vfs_parse_mount_options().
> Indeed, many filesystems today have uid= and gid= and
> umask= options that might be removed from the individual
> filesystems and put into vfs. After all, such options
> are also useful for (foreign) ext2 filesystems.]

    _Please_, if we do anything of that kind - let's use a new syscall.
    Ideally, I'd say
        fs_fd = open("/fs/ext2", O_RDWR);
        /* error -> no such filesystem */
        write(fs_fd. "/dev/sda1", strlen("/dev/sda1"));
        /* error handling */
        write(fs_fd, "reserve=5", strlen(....));
        ...
        dir = open("/usr/local", O_DIRECTORY);
        /* error handling */
        new_mount(dir, MNT_SET, fs_fd); /* closes dir and fs_fd */
        /* error handling */

    Comments?

I do not think this is an improvement. Anyway, it is orthogonal
to what I discussed.

[My version: keep interface constant, reorganize kernel source
to do certain things in one place instead of in several places.
Advantage: treatment becomes uniform and some options that make sense
for all filesystem types but are available today for some only
are generalized.
Your version: invent a new interface, be silent about what happens
inside the kernel.]

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jun 07 2001 - 21:00:28 EST