Re: [PATCH] drivers/net/others

From: Lars Marowsky-Bree (lmb@suse.de)
Date: Thu May 24 2001 - 03:51:37 EST

Next message: Andreas Dilger: "Re: Why side-effects on open(2) are evil. (was Re: [RFD w/info-PATCH]device arguments from lookup)"
Previous message: Pål Halvorsen: "sendfile"
In reply to: Tobias Ringstrom: "Re: [PATCH] drivers/net/others"
Next in thread: Andrzej Krzysztofowicz: "Re: [PATCH] drivers/net/others"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 2001-05-24T10:45:25,
Tobias Ringstrom <tori@unhappy.mine.nu> said:

> > if (!printed_version++)
> > - printk(version);
> > + printk("%s", version);
> >
> > DMFE_DBUG(0, "dmfe_init_one()", 0);
> >
>
> Could you please explain the purpose of this change? To me it looks less
> efficient in both performance and memory usage.

Potentially, version might include stuff which is interpreted by printk if not
quoted - the above fixes this. Paranoia always helps ;-)

Sincerely,
Lars Marowsky-Brée <lmb@suse.de>

-- Perfection is our goal, excellence will be tolerated. -- J. Yahl

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Andreas Dilger: "Re: Why side-effects on open(2) are evil. (was Re: [RFD w/info-PATCH]device arguments from lookup)"
Previous message: Pål Halvorsen: "sendfile"
In reply to: Tobias Ringstrom: "Re: [PATCH] drivers/net/others"
Next in thread: Andrzej Krzysztofowicz: "Re: [PATCH] drivers/net/others"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu May 31 2001 - 21:00:14 EST