Re: Fix for SMP deadlock in autofs4

From: Jeremy Fitzhardinge (jeremy@goop.org)
Date: Sat Apr 21 2001 - 02:02:56 EST


On Fri, Apr 20, 2001 at 10:59:43PM -0700, Linus Torvalds wrote:
> It's untested, but looks fairly obvious. It removes the increment, and
> changes autofs4_expire() to properly bump the count of the returned dentry
> (and callers will dput() it when done). This may be unnecessarily careful,
> but it's the RightThing(tm) to do.

I suppose so. It is pretty paranoid, because of autofs4's extra reference it
can't (shouldn't) ever drop to zero until the filesystem allows it to drop to
zero. In other words, if it helps, it's hiding another bug. But you're right,
if this were a general routine, it should definitely return with an elevated
count.

> Jeremy, would you mind verifying that this WorksForYou(tm)?

Looks fine to me. I'll give it a spin.

        J



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Apr 23 2001 - 21:00:39 EST