BUG: devfs/root doesn't follow pivot_root

From: Ph. Marek (marek@mail.bmlv.gv.at)
Date: Tue Mar 27 2001 - 02:00:10 EST

Next message: Nazim Khan: "Building linux kernel 2.4.0 for MIPS."
Previous message: Thomas Foerster: "URGENT : System hands on "Freeing unused kernel memory: ""
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Richard,

in fs/devfs/util.c is
void __init devfs_make_root (const char *name)
which is wrong as pivot_root allows changing the root-device in the runtime.

I think it should be
        void __init devfs_make_root (const char *name)
and get called by
fs/super.c:
        asmlinkage long sys_pivot_root(const char *new_root, const char *put_old)
after
        chroot_fs_refs(root,root_mnt,new_nd.dentry,new_nd.mnt);
        error = 0;

Is that correct?

Thanks for your attention,

regards

Phil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Nazim Khan: "Building linux kernel 2.4.0 for MIPS."
Previous message: Thomas Foerster: "URGENT : System hands on "Freeing unused kernel memory: ""
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Mar 31 2001 - 21:00:15 EST