Re: [PATCH] fix a bug in ioctl(CDROMREADAUDIO) in cdrom.c in 2.2

From: Jens Axboe (axboe@suse.de)
Date: Mon Mar 19 2001 - 06:24:36 EST


On Fri, Mar 16 2001, David Mansfield wrote:
> > Same thing for 2.4.2.
> >
> > Is my allocation loop "over engineering", or just plain bad thing to do ?
> >
>
> I've been running this (or close: my version tries 8 frames, then jumps
> immediately to 1, without trying 4 and 2 in between if the kmalloc
> fails) since it was changed. Without such a patch, my CDDA read speed
> drops to 25% the original rate. You also have the fix that started the
> thread!
>
> Jens (cdrom maintainer) said he was working on a more elegant solution,
> but to me, such a simple fix as yours should go in the kernel in the
> meantime. Jens?

I haven't integrated it yet, because of the vm printing memory
allocations errors. Which sort of destroys the idea of doing "clever"
allocations like this.

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 23 2001 - 21:00:12 EST