Re: [CHECKER] blocking w/ spinlock or interrupt's disabled

From: Linus Torvalds (torvalds@transmeta.com)
Date: Sun Mar 18 2001 - 22:24:25 EST


In article <001801c0af8e$bda30c10$5517fea9@local>,
Manfred Spraul <manfred@colorfullife.com> wrote:
>
>Unortunately schedule() with disabled interrupts is a feature, it's
>needed for the old (deprecated and waiting for termination in 2.5)
>sleep_on() functions.

Yes. But that should only cover "sleep_on()" and it's interruptible
cousing "sleep_on_interruptible()". No other blocking call should have
interrupts disabled, I would hope.

The special-case is a fairly specific "some old-style drivers avoid race
conditions by having interrupts disabled over explicit conditional
sleeps", not a generic "you may have interrupts disabled before
blocking".

                Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 23 2001 - 21:00:11 EST