Re: [PATCH] off-by-1 error in ide-probe (2.4.x)

From: Linus Torvalds (torvalds@transmeta.com)
Date: Sun Mar 18 2001 - 20:24:46 EST


On Mon, 19 Mar 2001 Andries.Brouwer@cwi.nl wrote:
>
> Agreed. That would be a trivially easy bug in the firmware, limiting to
> 255 sectors seems safer.
>
> Linus
>
> Yes, possibly.
> I checked old standards, and see that "0 means 256 as a sector count"
> is already in ATA-1.

Yes. But we could have some silly bug in the Linux drivers too, if some
part of the driver reads back the sector count and doesn't do the 0==256
conversion. So let's not blame the disk quite yet. Although it would be
interesting to hear if the problem only happens for a specific disk or
manufacturer...

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 23 2001 - 21:00:11 EST