Re: lingering loopback bugs?

From: Jens Axboe (axboe@suse.de)
Date: Sat Mar 03 2001 - 14:50:36 EST


On Sat, Mar 03 2001, Alexander Viro wrote:
> > Look for the patch I posted yesterday (hint: just remove these two
> > lines from loop_end_io_transfer)
> >
> > if (atomic_dec_and_test(&lo->lo_pending))
> > up(&lo->lo_bh_mutex);
>
> Uhh... And what will compensate for atomic_inc() in loop_make_request() in
> case of loop over block device?

There is no atomic_inc() in loop_make_request, I moved it to
count pending bh on the queue only. But hmm, we should not
be able to remove it while it has bhs in flight. Ok, I'll
rearrange this a bit again...

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Mar 07 2001 - 21:00:14 EST