Re: [PATCH] dlci: update last_rx after netif_rx

From: Arnaldo Carvalho de Melo (acme@conectiva.com.br)
Date: Mon Feb 26 2001 - 21:30:55 EST


Em Mon, Feb 26, 2001 at 09:56:13PM -0500, Jeff Garzik escreveu:
> Arnaldo Carvalho de Melo wrote:
> > --- linux-2.4.2/drivers/net/wan/dlci.c Tue Feb 13 19:15:05 2001
> > +++ linux-2.4.2.acme/drivers/net/wan/dlci.c Mon Feb 26 23:43:25 2001
> > @@ -229,6 +229,7 @@
> > skb_pull(skb, header);
> > netif_rx(skb);
> > dlp->stats.rx_packets++;
> > + dev->last_rx = jiffies;
>
> You need to update dlp->stats.rx_bytes too.

thanks, updated patch, there was no previous variable with the pkt lenght,
so I've added one, hope is ok.

- Arnaldo

--- linux-2.4.2/drivers/net/wan/dlci.c Tue Feb 13 19:15:05 2001
+++ linux-2.4.2.acme/drivers/net/wan/dlci.c Tue Feb 27 00:03:05 2001
@@ -205,7 +205,7 @@
 
                         case FRAD_P_IP:
                                 header = sizeof(hdr->control) + sizeof(hdr->IP_NLPID);
- skb->protocol = htons(ETH_P_IP);
+ skb->protocol = __constant_htons(ETH_P_IP);
                                 process = 1;
                                 break;
 
@@ -224,11 +224,14 @@
 
         if (process)
         {
+ int pktlen = skb->len;
                 /* we've set up the protocol, so discard the header */
                 skb->mac.raw = skb->data;
                 skb_pull(skb, header);
                 netif_rx(skb);
                 dlp->stats.rx_packets++;
+ dlp->stats.rx_bytes += pktlen;
+ dev->last_rx = jiffies;
         }
         else
                 dev_kfree_skb(skb);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Feb 28 2001 - 21:00:13 EST