Re: [PATCH] starfire reads irq before pci_enable_device.

From: Manfred Spraul (manfred@colorfullife.com)
Date: Thu Feb 08 2001 - 16:43:47 EST

Next message: Gerhard Mack: "Re: DNS goofups galore..."
Previous message: Jeff Garzik: "Re: [PATCH] starfire reads irq before pci_enable_device."
In reply to: Ion Badulescu: "Re: [PATCH] starfire reads irq before pci_enable_device."
Next in thread: Ion Badulescu: "Re: [PATCH] starfire reads irq before pci_enable_device."
Reply: Ion Badulescu: "Re: [PATCH] starfire reads irq before pci_enable_device."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Ion Badulescu wrote:
>
> > > +#if defined(__ia64__) || defined(__alpha__)
> > > +#define PKT_SHOULD_COPY(pkt_len) 1
> > > +#else
> > > +#define PKT_SHOULD_COPY(pkt_len) (pkt_len < rx_copybreak)
> > > +#endif
> >
> [snip]
>
> It's not *required* per se, as far as I know both the Alpha and IA64 have
> handlers for unaligned access traps. *However*, copying each packet is
> definitely better than taking an exception for each packet!
>

What about changing the default for rx_copybreak instead?
Set it to 1536 on ia64 and Alpha, 0 for the rest.
tulip and eepro100 use that aproach.

--
	Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Gerhard Mack: "Re: DNS goofups galore..."
Previous message: Jeff Garzik: "Re: [PATCH] starfire reads irq before pci_enable_device."
In reply to: Ion Badulescu: "Re: [PATCH] starfire reads irq before pci_enable_device."
Next in thread: Ion Badulescu: "Re: [PATCH] starfire reads irq before pci_enable_device."
Reply: Ion Badulescu: "Re: [PATCH] starfire reads irq before pci_enable_device."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Feb 15 2001 - 21:00:12 EST