Re: [PATCH] Remaining net/ pci_enable_device cleanups.

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Thu Feb 08 2001 - 12:45:38 EST

Next message: Linus Torvalds: "Re: select() returning busy for regular files [was Re: [Kiobuf-io-devel] RFC: Kernel mechanism: Compound event wait]"
Previous message: Jeff Hartmann: "Re: 2.4.x, drm, g400 and pci_set_master"
In reply to: Francois romieu: "Re: [PATCH] Remaining net/ pci_enable_device cleanups."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Francois romieu wrote:
>
> The Wed, Feb 07, 2001 at 10:48:17PM -0500, Jeff Garzik wrote :
> [...]
> > > diff -urN --exclude-from=/home/davej/.exclude linux/drivers/net/epic100.c linux-dj/drivers/net/epic100.c
> > > --- linux/drivers/net/epic100.c Wed Feb 7 21:55:56 2001
> > > +++ linux-dj/drivers/net/epic100.c Wed Feb 7 22:15:22 2001
> >
> > applied
>
> @@ -341,7 +341,7 @@
> static int printed_version;
> long ioaddr;
> int chip_idx = (int) ent->driver_data;
> - const int irq = pdev->irq;
> + int irq;
> struct net_device *dev;
> struct epic_private *ep;
> int i, option = 0, duplex = 0;
> @@ -354,10 +354,11 @@
> printk (KERN_INFO "%s" KERN_INFO "%s" KERN_INFO "%s",
> version, version2, version3);
>
> - i = pci_enable_device(pdev);
> - if (i)
> + if (pci_enable_device(pdev))
> return i;
>
> return i ? Looks bogus to me.

Definitely bogus and I forgot to mention that I fixed this up :)

Jeff

-- 
Jeff Garzik       | "You see, in this world there's two kinds of
Building 1024     |  people, my friend: Those with loaded guns
MandrakeSoft      |  and those who dig. You dig."  --Blondie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Linus Torvalds: "Re: select() returning busy for regular files [was Re: [Kiobuf-io-devel] RFC: Kernel mechanism: Compound event wait]"
Previous message: Jeff Hartmann: "Re: 2.4.x, drm, g400 and pci_set_master"
In reply to: Francois romieu: "Re: [PATCH] Remaining net/ pci_enable_device cleanups."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Feb 15 2001 - 21:00:12 EST