[PATCH] ATM breakage introduced in 2.4.0

• Next message: Andrea Arcangeli: "Re: 2.4.1-pre1 breaks XFree 4.0.2 and "w""
• Previous message: Adam Scislowicz: "2.4.0 on a bigmemory machine (2GB) with ramdisk+initrd"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,
2.4.0 introduced serious breakage to LANE. It's impossible to do
ifdown lec? ; ifup lec? because memory allocated by lec? is freed but
unregister_netdev() is not called, so SIOCGIFFLAGS tells me ok, but
SIOCSIFFLAGS tells me -ENODEV. No, rmmod lec ; insmod lec does not help.
Patch follows

--- linux/net/atm/lec.c.orig Thu Jan 11 19:40:50 2001
+++ linux/net/atm/lec.c Thu Jan 11 19:42:20 2001
@@ -858,8 +858,11 @@
                 if (dev_lec[i] != NULL) {
                         priv = (struct lec_priv *)dev_lec[i]->priv;
 #if defined(CONFIG_TR)
- unregister_trdev(dev_lec[i]);
+ if (priv->is_trdev)
+ unregister_trdev(dev_lec[i]);
+ else
 #endif
+ unregister_netdev(dev_lec[i]);
                         kfree(dev_lec[i]);
                         dev_lec[i] = NULL;
                 }

And it would be nice if I was able to build Fore 200e driver in 2.4.1 ;)

--- linux/drivers/atm/Makefile.orig Tue Jan 2 10:18:25 2001
+++ linux/drivers/atm/Makefile Tue Jan 2 12:00:05 2001
@@ -46,7 +46,7 @@
   endif
 endif
 
-obj-$(CONFIG_ATM_FORE200E) += fore200e.o $(FORE200E_FW_OBJS)
+obj-$(CONFIG_ATM_FORE200E) += fore_200e.o
 
 include $(TOPDIR)/Rules.make

Jan

-- 
Jan Rękorajski            |  ALL SUSPECTS ARE GUILTY. PERIOD!
baggins<at>mimuw.edu.pl   |  OTHERWISE THEY WOULDN'T BE SUSPECTS, WOULD THEY?
BOFH, MANIAC              |                   -- TROOPS by Kevin Rubio
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Andrea Arcangeli: "Re: 2.4.1-pre1 breaks XFree 4.0.2 and "w""
• Previous message: Adam Scislowicz: "2.4.0 on a bigmemory machine (2GB) with ramdisk+initrd"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Jan 15 2001 - 21:00:31 EST