test13-pre5: Double flush_cache_page?

From: Russell King (rmk@arm.linux.org.uk)
Date: Fri Dec 29 2000 - 06:52:08 EST


Hi,

Is the following really intentional?

vmscan.c:122:

        flush_cache_page(vma, address);
        if (!pte_dirty(pte))
                goto drop_pte;
        ...
        flush_cache_page(vma, address);
        if (page->mapping) {

Nothing accesses the actual page between the two flush_cache_page() calls,
the first one was added in test13-pre5. Should test13-pre5 have removed
the second instance?
   _____
  |_____| ------------------------------------------------- ---+---+-
  | | Russell King rmk@arm.linux.org.uk --- ---
  | | | | http://www.arm.linux.org.uk/personal/aboutme.html / / |
  | +-+-+ --- -+-
  / | THE developer of ARM Linux |+| /|\
 / | | | --- |
    +-+-+ ------------------------------------------------- /\\\ |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Dec 31 2000 - 21:00:12 EST