Re: test13-pre5

From: Marcelo Tosatti (marcelo@conectiva.com.br)
Date: Thu Dec 28 2000 - 17:14:55 EST


On Thu, 28 Dec 2000, Linus Torvalds wrote:

> - make "SetPageDirty()" do something like
>
> if (!test_and_set(PG_dirty, &page->flags)) {
> spin_lock(&page_cache_lock);
> list_del(page->list);
> list_add(page->list, page->mapping->dirty_pages);
> spin_unlock(&page_cache_lock);
> }
>
> This will require making sure that every place that does a
> SetPageDirty() will be ok with this (ie double-check that they all have
> a mapping: right now the free_pte() code in mm/memory.c doesn't care,
> because it knew that it coul dmark even anonymous pages dirty and
> they'd just get ignored.
> - make a filemap_fdatasync() that walks the dirty pages and does a
> writepage() on them all and moves them to the clean list.

We also want to move the page to the per-address-space clean list in
ClearPageDirty I suppose.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Dec 31 2000 - 21:00:12 EST