Re: innd mmap bug in 2.4.0-test12

From: Rik van Riel (riel@conectiva.com.br)
Date: Thu Dec 28 2000 - 13:02:49 EST

Next message: Linus Torvalds: "Re: [Patch] shmem_unuse race fix"
Previous message: Linus Torvalds: "Re: [PATCH] not sleep while holding a locked page in block_truncate_page"
In reply to: Linus Torvalds: "Re: innd mmap bug in 2.4.0-test12"
Next in thread: Zlatko Calusic: "Re: innd mmap bug in 2.4.0-test12"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, 28 Dec 2000, Linus Torvalds wrote:
> On Thu, 28 Dec 2000, Rik van Riel wrote:
> >
> > I've made a small debugging patch that simply checks
> > for this illegal state in add_page_to_active_list and
> > add_page_to_inactive_dirty_list.
>
> I bet it won't catch the real bad guy, which almost certainly is
> the "remove_from_swap_cache()" thing (it should do a
> ClearPageDirty() before it removes it from the swapper_inode
> mapping).

Ohhh indeed. This is a very likely candidate which is
trivial to fix.

regards,

Rik

-- Hollywood goes for world dumbination, Trailer at 11.

http://www.surriel.com/ http://www.conectiva.com/ http://distro.conectiva.com.br/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/

Next message: Linus Torvalds: "Re: [Patch] shmem_unuse race fix"
Previous message: Linus Torvalds: "Re: [PATCH] not sleep while holding a locked page in block_truncate_page"
In reply to: Linus Torvalds: "Re: innd mmap bug in 2.4.0-test12"
Next in thread: Zlatko Calusic: "Re: innd mmap bug in 2.4.0-test12"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Dec 31 2000 - 21:00:11 EST