On Tue, 17 Oct 2000, Horst von Brand wrote:
> Richard Guenther <richard.guenther@student.uni-tuebingen.de> said:
> > The following one is wrong, tho - should be rather
> > str[i] = dn[i]; i++;
>
> > > diff -x log.build -x .* -dru linux-2.4/drivers/isdn/sc/debug.c linux-2.4-fixe
> > d/drivers/isdn/sc/debug.c
> > > --- linux-2.4/drivers/isdn/sc/debug.c Thu Apr 2 01:21:04 1998
> > > +++ linux-2.4-fixed/drivers/isdn/sc/debug.c Mon Oct 16 14:53:49 2000
> > > @@ -70,6 +70,6 @@
> > > int i = 0;
> > >
> > > while(dn[i] != ',')
> > > - str[i] = dn[i++];
> > > + str[i] = dn[i], i++;
> > > str[i] = 0x0;
>
> What is wrong with plain and simple:
>
> for(i = 0; dn[i] != ','; i++)
> str[i] = dn[i];
> str[i] = '\0';
Nothing. Feel free to submit a better patch. I was just trying to correct
the code with the minimum set of modifications so as to avoid breaking
anything by accident.
Bernd
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Oct 23 2000 - 21:00:11 EST