Re: PATCH 2.4.0.10.3: pc_keyb and q40_keyb cleanup

From: Linus Torvalds (torvalds@transmeta.com)
Date: Mon Oct 16 2000 - 11:50:52 EST


On Mon, 16 Oct 2000, Andrea Arcangeli wrote:

> On Sun, Oct 15, 2000 at 03:48:55PM -0400, Jeff Garzik wrote:
> > Changes:
> > * both: we know we are in an interrupt, so
> > s/spin_lock_irqsave/spin_lock/
>
> There request_irq is not called passing the SA_INTERRUPT flag so the irq
> handler is recalled with irqs enabled and in turn irqsave is necessary.

And don't try to use SA_INTERRUPT: it is a no-op on many architectures,
including, in the future, x86.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 23 2000 - 21:00:09 EST