[Q] init_etherdev()

• Next message: mmcdonald@123go.com: "Top 5 Web Sites"
• Previous message: H. Peter Anvin: "Re: Device Driver"
• Next in thread: Jeff Garzik: "Re: [Q] init_etherdev()"
• Reply: Jeff Garzik: "Re: [Q] init_etherdev()"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi all,

after walking through some of NIC drivers and trying to remove check_region()
calls, i have two small questions:

1) many NIC drivers contain (in XXX_probe1 functions) check like this:
        
        if (dev == NULL) {
                    dev = init_etherdev();
        }

but many drivers don't check (dev == NULL) at all. So first question: is this check
and init_etherdev() call really required or this is old crap waiting for removal ?

2) if init_etherdev() is required, than call to unregister_netdevice() is
required too (in case of probe failure), isn't it ?

Best regards,
            Andrey
            
P.S. IMHO my English is especially bad today, so I'm sorry :)

-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

• Next message: mmcdonald@123go.com: "Top 5 Web Sites"
• Previous message: H. Peter Anvin: "Re: Device Driver"
• Next in thread: Jeff Garzik: "Re: [Q] init_etherdev()"
• Reply: Jeff Garzik: "Re: [Q] init_etherdev()"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Oct 23 2000 - 21:00:08 EST