On Thu, 12 Oct 2000, David S. Miller wrote:
>
> page_table_lock is supposed to protect normal page table activity (like
> what's done in page fault handler) from swapping out.
> However, grabbing this lock in swap-out code is completely missing!
>
> Audrey, vmlist_access_{un,}lock == unlocking/locking page_table_lock.
Yeah, it's an easy mistake to make.
I've made it myself - grepping for page_table_lock and coming up empty in
places where I expected it to be.
In fact, if somebody sends me patches to remove the "vmlist_access_lock()"
stuff completely, and replace them with explicit page_table_lock things,
I'll apply it pretty much immediately. I don't like information hiding,
and right now that's the only thing that the vmlist_access_lock() stuff is
doing.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Oct 15 2000 - 21:00:24 EST