Re: test9pre6 usb-storage

From: Matthew Dharm (mdharm-kernel@one-eyed-alien.net)
Date: Sun Sep 24 2000 - 16:08:34 EST

I'm the usb-storage maintainer. Yes, I realize that there is really no
need to reset the state to TASK_RUNNING, but I felt better having those
there. Considering that code is from the reset routines which almost never
get called, I figured it was fine.

Matt

On Sun, Sep 24, 2000 at 03:55:34PM +0100, John Levon wrote:
>
> These chunks :
>
> /* long wait for reset */
> + set_current_state(TASK_UNINTERRUPTIBLE);
> schedule_timeout(HZ*6);
> + set_current_state(TASK_RUNNING);
>
> and
>
> + /* long wait for reset */
> + set_current_state(TASK_UNINTERRUPTIBLE);
> + schedule_timeout(HZ*6);
> + set_current_state(TASK_RUNNING);
>
> seem slightly wrong. Unless someone wants to correct me, there
> should be no need to set TASK_RUNNING after schedule_timeout()
> has been called.
>
> john
>
> p.s. I am not subscribed to linux-usb-devel
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> Please read the FAQ at http://www.tux.org/lkml/ 

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

Sir, for the hundreth time, we do NOT carry 600-round boxes of belt-fed 
suction darts!
					-- Salesperson to Greg
User Friendly, 12/30/1997
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sat Sep 30 2000 - 21:00:12 EST