Re: [PATCH] devfs support for LVM

From: Richard Gooch (rgooch@ras.ucalgary.ca)
Date: Tue Sep 05 2000 - 17:41:26 EST


Christoph Hellwig writes:
> Hi Linus,
> I've updated my devfs for lvm patch to 2.4.0-test8pre.
> Here it is.
[...]
> + lvm_devfs_handle = devfs_register(
> + 0 , "lvm", 0, 0, LVM_CHAR_MAJOR,

Does this really have to go into /dev rather than a subdirectory?

[...]
> + vg_devfs_handle[vg_ptr->vg_number] = devfs_mk_dir(0, vg_ptr->vg_name, NULL);

I don't know what directory you're creating for the stuff below, but
can you put all the LVM stuff under /dev/lvm/ please? Then make the
"lvm" char entry above /dev/lvm/control or something like that?

> + ch_devfs_handle[vg_ptr->vg_number] = devfs_register(
> + vg_devfs_handle[vg_ptr->vg_number] , "group",
> + DEVFS_FL_DEFAULT, LVM_CHAR_MAJOR, vg_ptr->vg_number,
> + S_IFCHR | S_IRUSR | S_IWUSR | S_IRGRP,
> + &lvm_chr_fops, NULL);
[...]
> + lv_devfs_handle[lv->lv_number] = devfs_register(
> + vg_devfs_handle[vg_ptr->vg_number], lv_buf,
> + DEVFS_FL_DEFAULT, LVM_BLK_MAJOR, lv->lv_number,
> + S_IFBLK | S_IRUSR | S_IWUSR | S_IRGRP,
> + &lvm_blk_dops, NULL);

Are these in a subdirectory

                                Regards,

                                        Richard....
Permanent: rgooch@atnf.csiro.au
Current: rgooch@ras.ucalgary.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Sep 07 2000 - 21:00:23 EST