Re: 2.4.0-test8-pre1 is quite bad / how about integrating Rik's VM now?

From: Chris Mason (mason@suse.com)
Date: Mon Sep 04 2000 - 11:39:11 EST


On 9/3/00, 3:20:01 AM, Alexander Viro <viro@math.psu.edu> wrote regarding
Re: 2.4.0-test8-pre1 is quite bad / how about integrating Rik's VM now?:

> On Sat, 2 Sep 2000, Linus Torvalds wrote:

> > Not at all. In fact, I'd prefer it that way, because this same thing is
> > obviously going to be useful for any other block filesystem with the same
> > issue.

[ fs list of truncate fun ]

Thanks, it should be useable on reiserfs, and I'm neck deep in
reiserfs_truncate right now anyway. The packed files don't care about
this at all, they get read into a zero'd page for readpage, or unpacked
for writing. The unpacked tails will need a similar change to the one in
ext2.

> <evil grin>
> I wonder how much of the crap fixed lately would be caught by
> Reiserfs Mighty Benchmark Suite(tm) (main testing tool, according to
> Hans). Could somebody take it and run on ext2 from, say it, 2.4.0-test1?
> Might be interesting...

;-)

test1 had rare file data corruption, test2 was not at all pretty. The
tools aren't there to test VFS, or even the correctness of a given file
op (those tests are done by hand when we make changes). There are two
common mistakes that we (reiserfs coders) make: missing a brelse, and not
dealing properly with a schedule. The load scripts are very good at
finding those.

-chris

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Sep 07 2000 - 21:00:19 EST