[patch] today's "signed char" sin bin

From: Philip Blundell (pb@tazenda.demon.co.uk)
Date: Sun Sep 03 2000 - 17:08:44 EST


Here's the latest collection of drivers that assumed "char" is always signed.

p.

Index: drivers/net/eepro100.c
===================================================================
RCS file: /cvsroot/pub/kernel/armlinux/drivers/net/eepro100.c,v
retrieving revision 1.15
diff -u -p -u -r1.15 eepro100.c
--- drivers/net/eepro100.c 2000/08/27 19:25:16 1.15
+++ drivers/net/eepro100.c 2000/09/03 21:54:12
@@ -528,7 +528,7 @@ struct speedo_private {
         struct speedo_mc_block *mc_setup_tail;/* Multicast setup frame list tail. */
         int in_interrupt; /* Word-aligned dev->interrupt */
         unsigned char acpi_pwr;
- char rx_mode; /* Current PROMISC/ALLMULTI setting. */
+ signed char rx_mode; /* Current PROMISC/ALLMULTI setting. */
         unsigned int tx_full:1; /* The Tx queue is full. */
         unsigned int full_duplex:1; /* Full-duplex operation requested. */
         unsigned int flow_ctrl:1; /* Use 802.3x flow control. */
Index: drivers/net/rtl8129.c
===================================================================
RCS file: /cvsroot/pub/kernel/armlinux/drivers/net/rtl8129.c,v
retrieving revision 1.5
diff -u -p -u -r1.5 rtl8129.c
--- drivers/net/rtl8129.c 2000/08/02 19:38:07 1.5
+++ drivers/net/rtl8129.c 2000/09/03 21:54:17
@@ -271,7 +271,7 @@ struct rtl8129_private {
         unsigned char *tx_bufs; /* Tx bounce buffer region. */
         dma_addr_t rx_ring_dma;
         dma_addr_t tx_bufs_dma;
- char phys[4]; /* MII device addresses. */
+ signed char phys[4]; /* MII device addresses. */
         char twistie, twist_cnt; /* Twister tune state. */
         unsigned int tx_full:1; /* The Tx queue is full. */
         unsigned int full_duplex:1; /* Full-duplex operation requested. */
Index: drivers/char/rio/rioctrl.c
===================================================================
RCS file: /cvsroot/pub/kernel/armlinux/drivers/char/rio/rioctrl.c,v
retrieving revision 1.2
diff -u -p -u -r1.2 rioctrl.c
--- drivers/char/rio/rioctrl.c 2000/05/27 21:54:17 1.2
+++ drivers/char/rio/rioctrl.c 2000/09/03 21:53:01
@@ -1807,7 +1807,7 @@ uchar Cmd;
                 return RIO_FAIL;
         }
 
- if (((int)((char)PortP->InUse) == -1) || ! (CmdBlkP = RIOGetCmdBlk()) ) {
+ if (((int)((signed char)PortP->InUse) == -1) || ! (CmdBlkP = RIOGetCmdBlk()) ) {
                 rio_dprint(RIO_DEBUG_CTRL, ("Cannot allocate command block for command %d on port %d\n",
                        Cmd, PortP->PortNum));
                 return RIO_FAIL;
@@ -1882,7 +1882,7 @@ uchar Cmd;
                         ** allowed then we should not bother sending any more to the
                         ** RTA.
                         */
- if ((int)((char)PortP->WflushFlag) == (int)-1) {
+ if ((int)((signed char)PortP->WflushFlag) == (int)-1) {
                                 rio_dprint(RIO_DEBUG_CTRL, ("Trashed WFLUSH, WflushFlag about to wrap!"));
                                 RIOFreeCmdBlk(CmdBlkP);
                                 return(RIO_FAIL);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Sep 07 2000 - 21:00:16 EST