Re: 2.4.0-test7 spurious '##' patches

From: Keith Owens (kaos@ocs.com.au)
Date: Thu Aug 31 2000 - 23:56:40 EST


On Thu, 31 Aug 2000 21:44:16 -0700,
Richard Henderson <rth@twiddle.net> wrote:
>On Thu, Aug 31, 2000 at 07:09:00PM +1100, Keith Owens wrote:
>> Compiling 2.4.0-test7 with the latest IA64 toolchain, gcc version
>> 2.96-ia64-000717 snap 000828. It complained about various include
>> files, "pasting would not give a valid preprocessing token", this
>> version of gcc is a bit more paranoid about the use of '##'.
>
>> -#define dprintk(args...) dfprintk(FACILITY, ## args)
>> +#define dprintk(args...) dfprintk(FACILITY, args)
>
>This one isn't. This is a gcc extension to remove the previous token
>if "args" is empty. So you'd get
>
> dfprintk(FACILITY);
>instead of
> dfprintk(FACILITY, );

I know about that extension and I originally tried
dfprintk(FACILITY , ##args) which is what gcc info recommends, but that
still gave a warning message. Since this particular macro requires at
least one argument (dprintk() and dfprintk(FACILITY) are meaningless),
it was easier to remove the '##'.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Sep 07 2000 - 21:00:10 EST