Re: an assortment of memory alloc/dealloc errors

From: Dawson Engler (engler@csl.Stanford.EDU)
Date: Thu Aug 10 2000 - 05:56:30 EST


Greg,

I sent out a new message today that filtered out (hopefully all/most)
such false positives. If you're going to poke around some more, it's
probably best to use it rather than the unannotated (and false positive
containing) tail end of my first message. The heuristic: if there's
code from the kernel by the error messsage, its something I didn't see
as an obvious false positive. Otherwise it could go either way.

Thanks for confirming the errors, and apologies for the time wasted
on the others.

Dawson

>
> On Tue, Aug 08, 2000 at 06:40:17PM -0700, Dawson Engler wrote:
>
> > /u2/engler/ic/linux-2.3.99/drivers/usb/usb.c:686:usb_request_bulk: ERROR: Unchecked use of malloc'd var 'awd'
> > /u2/engler/ic/linux-2.3.99/drivers/usb/usb.c:779:usb_request_irq: ERROR: Unchecked use of malloc'd var 'wd'
>
> These functions are no longer in the most recent code.
>
> > /u2/engler/ic/linux-2.3.99/drivers/usb/plusb.c:391:plusb_alloc: ERROR: did not free skb on error path
> > /u2/engler/ic/linux-2.3.99/drivers/usb/plusb.c:391:plusb_alloc: ERROR: did not free skb on error path
> > /u2/engler/ic/linux-2.3.99/drivers/usb/plusb.c:391:plusb_alloc: ERROR: did not free skb on error path
>
> These look like real errors. Deti, could you look into fixing these?
>
> > /u2/engler/ic/linux-2.3.99/drivers/usb/usb-ohci.c:487:sohci_submit_urb: ERROR: did not free urb_priv on error path
>
> The memory is freed in the call to urb_rm_priv, so this is a false
> positive.
>
> > /u2/engler/ic/linux-2.3.99/drivers/usb/usb-uhci.c:653:init_skel: ERROR: did not free s on error path
>
> The memory is freed in the call to cleanup_skel, so this is also a false
> positive.
>
> Thanks for reporting these.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Aug 15 2000 - 21:00:21 EST