Re: [patch] 2.4.0-test6-pre8: Magic SysRq fixes for serial.c

From: Theodore Y. Ts'o (tytso@MIT.EDU)
Date: Wed Aug 09 2000 - 10:39:57 EST


   Date: Wed, 9 Aug 2000 14:33:01 +0200 (MET DST)
   From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>

    Ugh, I admit I haven't actually checked it even though I should have to.
   But this poses a problem in serial.c (and possibly other serial drivers,
   too) -- it needs to check if SysRq is enabled even before calling
   handle_sysrq(). Otherwise the character immediately preceding the BREAK
   condition gets lost for no reason. When handle_sysrq() gets finally
   called, it's already too late -- the chacter have already been lost.

No, only the break character, and possibly the character following that
may get lost. And this only happens if you've configured a serial
console. (a) BREAK doesn't happen all that often on serial lines to
begin with, these days, and (b) it's very unlikely to happen on the
serial console.

This doesn't necessarily mean that we shouldn't fix this, but let's keep
things in perspective...... This is not what I would call
earth-shatterring. :-)

                                                        - Ted

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Aug 15 2000 - 21:00:18 EST