Re: [PATCH] partial fix for Thinkpads and suspend

• Next message: BenHanokh Gabriel: "mapping from dev_t to device name"
• Previous message: Maciej W. Rozycki: "Re: [PATCH] fix SMP kernel on SMP MoBo with APIC-less CPU"
• In reply to: Garst R. Reese: "Re: [PATCH] partial fix for Thinkpads and suspend"
• Next in thread: Garst R. Reese: "Re: [PATCH] partial fix for Thinkpads and suspend"
• Reply: Garst R. Reese: "Re: [PATCH] partial fix for Thinkpads and suspend"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Garst,

"Garst R. Reese" <reese@isn.net> writes:
>
> Hmm, how does changing APM_DO_CLI fix the fact that in test5-pre2, an
> explicit cli() was issued? (in the function suspend at line 914).
> I do not understand how you avoid that cli.

I don't :-)
BUT after the cli() call, suspend() calls apm_set_power_state()
which calls set_power_state() which calls apm_bios_call_simple()
which (after my patch) will do __sti() (in APM_DO_CLI) for you
(if you have CONFIG_APM_ALLOW_INTS set) ...

Please try the patch ...

Cheers,
Stephen

-- 
Stephen Rothwell, Open Source Researcher, Linuxcare, Inc.
+61-2-62628990 tel, +61-2-62628991 fax 
sfr@linuxcare.com, http://www.linuxcare.com/ 
Linuxcare. Support for the revolution.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: BenHanokh Gabriel: "mapping from dev_t to device name"
• Previous message: Maciej W. Rozycki: "Re: [PATCH] fix SMP kernel on SMP MoBo with APIC-less CPU"
• In reply to: Garst R. Reese: "Re: [PATCH] partial fix for Thinkpads and suspend"
• Next in thread: Garst R. Reese: "Re: [PATCH] partial fix for Thinkpads and suspend"
• Reply: Garst R. Reese: "Re: [PATCH] partial fix for Thinkpads and suspend"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Aug 15 2000 - 21:00:17 EST