BUG in fs/ext2/super.c

From: Andreas Gruenbacher (a.gruenbacher@bestbits.at)
Date: Wed Jul 19 2000 - 13:19:31 EST


Al and all,

there is a bug in fs/ext2/super.c, which I've reported to Al Viro before
(-test1) with no reaction. Could someone _please_ verify that issue and
convice Al Viro this needs fixing. Thanks.

Problem: parse_options() is called with a pointer to uninitialized
new_mount_opt
in line 660. This may result is arbitrary mount options after a remount
of an ext2 filesystem.

Thise patch is against 2.4.0-test4.

--- fs/ext2/super.c.bug Wed Jul 19 20:02:37 2000
+++ fs/ext2/super.c Wed Jul 19 20:15:54 2000
@@ -657,6 +657,7 @@
        /*
         * Allow the "check" option to be passed as a remount option.
         */
+ new_mount_opt = sb->u.ext2_sb.s_mount_opt;
        if (!parse_options (data, &tmp, &resuid, &resgid,
                            &new_mount_opt))
                return -EINVAL;

Regards,
Andreas

------------------------------------------------------------------------
 Andreas Gruenbacher, a.gruenbacher@computer.org
 Contact information: http://www.bestbits.at/~ag/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jul 23 2000 - 21:00:15 EST