Re: 2.4.0-test5-pre1: renice priorities problem

From: Linus Torvalds (torvalds@transmeta.com)
Date: Tue Jul 18 2000 - 17:53:58 EST


In article <3973B3BF.CC6DD810@norran.net>,
Roger Larsson <roger.larsson@norran.net> wrote:
>Hi,
>
>When testing other stuff with kernel 2.4.0-test5-pre1
>
>I found that
>
>> renice 2 pid
><pid>: old priority 0, new priority 2
>
>> renice 3 pid
><pid>: old priority -2, new priority 3
>
>One is wrong...

Uhhuh. I think the old binary interface to "sys_getpriority()" was "20 -
nice", and the new code does "20 + nice". So the sign gets set wrong.

Try changing sys_getpriority() to say

        niceval = 20 - p->nice;

instead of

        niceval = p->nice + 20;

and we should be returning the same (fairly nonsensical, but they avoid
the error code return triggering) numbers we always used to.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jul 23 2000 - 21:00:11 EST