Re: nmi_counter cleanup

From: Ingo Molnar (mingo@elte.hu)
Date: Tue Jul 18 2000 - 04:49:22 EST


On Tue, 18 Jul 2000, Keith Owens wrote:

> This patch against 2.4.0-test5-pre2 :-
>
> (1) Changes nmi_counter from atomic_t to unsigned int. nmi_counter is
> per cpu and is only updated from the owning cpu. There is no need
> for it to be atomic, [...]

yep.

> [...] the lock prefix just slows things down,
> especially with the NMI oopser going.

no real (visible) slowdown there - the code is run at most HZ times per
second per CPU.

> Any objections before I send it to Linus?

no objections at all.

        Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jul 23 2000 - 21:00:10 EST