md.c and -Werror

From: Thorsten Kranzkowski (th@Marvin.DL8BCU.ampr.org)
Date: Fri Jul 07 2000 - 04:06:15 EST


Hello!
I get an error compiling md.c.
Since both mddev->sb and the argument of clear_page() seem to be pointers
I just removed the cast. Is that correct?

Bye,
Thorsten

Alpha AXPpxi33 'noname'
gcc version 2.96 20000530 (experimental)

gcc -D__KERNEL__ -I/usr/src/linux-2.4.0-test3-pre5-work/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -Werror -fno-strict-aliasing -pipe -mno-fp-regs -ffixed-8 -mcpu=ev4 -Wa,-mev6 -DEXPORT_SYMTAB -c md.c
In file included from /usr/src/linux-2.4.0-test3-pre5-work/include/linux/raid/md.h:35,
                 from md.c:32:
/usr/src/linux-2.4.0-test3-pre5-work/include/linux/delay.h:19:44: warning: trigraph ??/ ignored
cc1: warnings being treated as errors
md.c: In function `alloc_array_sb':
md.c:499: warning: passing arg 1 of `clear_page' makes pointer from integer without a cast
md.c: In function `alloc_disk_sb':
md.c:513: warning: passing arg 1 of `clear_page' makes pointer from integer without a cast
make[3]: *** [md.o] Error 1

--- linux-2.4.0-test2/drivers/block/md.c Thu Jul 6 18:05:56 2000
+++ linux-2.4.0-test3-pre5-work/drivers/block/md.c Fri Jul 7 08:57:21 2000
@@ -496,7 +496,7 @@
         mddev->sb = (mdp_super_t *) __get_free_page (GFP_KERNEL);
         if (!mddev->sb)
                 return -ENOMEM;
- md_clear_page((unsigned long)mddev->sb);
+ md_clear_page(mddev->sb);
         return 0;
 }
 
@@ -510,7 +510,7 @@
                 printk (OUT_OF_MEM);
                 return -EINVAL;
         }
- md_clear_page((unsigned long)rdev->sb);
+ md_clear_page(rdev->sb);
 
         return 0;
 }

-- 
| Thorsten Kranzkowski        Internet: dl8bcu@gmx.net                        |
| Mobile: ++49 170 1876134       Snail: Niemannsweg 30, 49201 Dissen, Germany |
| Ampr: dl8bcu@db0lj.#rpl.deu.eu, dl8bcu@marvin.dl8bcu.ampr.org [44.130.8.19] |

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:20 EST