Re: console_lock too early in printk???

From: Chris Lattner (sabre@skylab.org)
Date: Sun Jul 02 2000 - 13:48:34 EST


> Hint: do we care about the buffer that vsprintf is writing to? Do
> we care that the messages could get corrupted? What's the point in
> preventing two threads writing to the same memory space?

Yes, I understand now that buf was actually being protected by the console
lock. It was just a minor oversight! :)

-Chris

> Generally, calling printk with pointers to user-memory is not a good
> thing to do - think about why we have copy_from_user/get_user/
> strncopy_from_user and friends. IMHO, you're calling printk in an
> illegal way, so it won't behave nicely to you.
> _____
> |_____| ------------------------------------------------- ---+---+-
> | | Russell King rmk@arm.linux.org.uk --- ---
> | | | | http://www.arm.linux.org.uk/~rmk/aboutme.html / / |
> | +-+-+ --- -+-
> / | THE developer of ARM Linux |+| /|\
> / | | | --- |
> +-+-+ ------------------------------------------------- /\\\ |
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:11 EST