Alan Cox <alan@lxorguk.ukuu.org.uk> said:
> > +++ linux-2.2.17pre/drivers/net/8390.c Sat Jul 1 23:16:11 2000
> > @@ -176,7 +176,6 @@
> > /* Opposite of above. Only used when "ifconfig <devname> down" is done. */
> > int ei_close(struct device *dev)
> > {
> > - struct ei_device *ei_local = (struct ei_device *) dev->priv;
> This is wrong
Why? The variable isn't used anywhere I can see. If there is some hidden
use (perhaps only in SMP?), a comment would be useful.
[...]
> > + __asm__ __volatile__ ( \
> > + "movw %w3,%w2\n\t" \
> > + "movw %w4,%w3\n\t" \
> > + "movl %2,%0\n\t" \
>
> This lot cannot be changed without breaking older binutils
You lost me there. AFAIKS, if this breaks with old binutils, they are just
broken way beyond hope. This just tells gcc to generate:
movw %ax, %dx
instead of (clearly wrong!):
movw %eax,%edx
It might be right to stay with known broken tools to not rock the boat for
a stable kernel series, but _please_ get rid of that crap for 2.4
-- Horst von Brand vonbrand@sleipnir.valparaiso.cl Casilla 9G, Vin~a del Mar, Chile +56 32 672616- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:11 EST