>> = Adam Richter
> = Alan Cox
>> -static char *lvm_snap_version = "LVM 0.8final (15/02/2000)\n";
>> +/* LVM 0.8final (15/02/2000) */
>This breaks the ability to pull the version from the binary. Use
>static __attribute__((unused)) char *
>[yes its ugly but define __unused maybe]
I know its only a few bytes, but, just in the interests
of code readability and having a consistent standard across the
rest of kernel, let me suggest putting it in MODULE_DESCRIPTION()
if you want the user to be able to extract it from the module binary.
Using MODULE_DESCRIPTION would have the following advantages:
1. Does not consume unswappable kernel space.
2. Allows these information strings to be handled in a
uniform manner in the future.
3. Makes it easier to support this information in tools more
precise than "strings module.o | grep ..."
I can resubmit my patch with this change if anybody wants me to.
Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
adam@yggdrasil.com \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:11 EST