Re: [PATCH] Make printk lock when appropriate...

From: Chris Lattner (sabre@skylab.org)
Date: Sat Jul 01 2000 - 20:32:31 EST


> > > of the console lock to after the vsprintf. It would be nice if this went
> > > into 2.4.0 final, especially since it's such a trivial change...
> > Sorry, but the patch is wrong.
> > "buf" is a static variable, defined in line 28 [printk.c]
> However, printk is the only function using it. Why not move it into
> printk? Is 1024 bytes too large for the kernel stack?

Nope, can't reasonably go onto the (very small) kernel stack... :(

> BTW, the variable buf is also declared in other functions. Not so nice.

In patch attempt #2, I just made it a static in printk... hopefully that
will clear up some confusion... :)

-Chris

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:10 EST