On Sun, 25 Jun 2000, Marcelo Tosatti wrote:
>On Mon, 26 Jun 2000, Andrea Arcangeli wrote:
>
>> On Sun, 25 Jun 2000, Marcelo Tosatti wrote:
>>
>> >With the attached patch, try_to_free_buffers() wakes up kflushd if the
>> >percentage of dirty memory is high, independant of sync_page_buffers
>>
>> It's wrong to do that there. kflushd is just wakenup by the guy that
>> generated the dirty data.
>Why that is wrong?
It's wrong the place where you wake it up. We just do the wakeup in the
right place anyway (and we do write throttling too if necessary), so you
don't need to do an extra wasteful check there. If kflushd wasn't running
and it was expected to be running, then fix the real wakeup point instead
of bloating the allocator path.
If it's not running there please try the flushing changes I pointed you in
earlier email first and report if it still doesn't wakeup right, thanks!
Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Jun 26 2000 - 21:00:07 EST