Re: [patch-2.4.0-test2]Re: Linux-2.4.0-test2

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Sat Jun 24 2000 - 15:14:59 EST


> So all drivers (I'm sure there are a few) that use something like
>
> struct foo {
> u32 a;
> u32 b;
> u32 c;
> u32 d;
> }
>
> to communicate with some hardware (4 32-bit values with addresses in
> sequence) should be fixed not to make assumptions about the layout of a
> struct?

You need to be very very careful doing it. Rusty found this out recently
with netfilter. I had problems in 2.1.x with SYS5fs for similar reasons - the
m68k packs on 16bit boundaries so all the superblocks were the wrong size.
Thankfully the author at least checked the size and panic()ed on error

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jun 26 2000 - 21:00:06 EST