PATCH: msp3400.c crash in ac17 (and before)

From: almesber@lrc.di.epfl.ch
Date: Tue Jun 13 2000 - 06:03:06 EST


Kernel threads which are launched before the root FS is ready still
crash in /proc with ac17. msp3400 is among them. Alex, unless you think
you'll have the clean solution (that "jail"/"null"/"mini" FS) ready
very soon, I'd suggest to include the attached patch.

It fixes the problem from the msp3400 side and is probably desirable
even later (unless exit_fs gets pulled into kernel_thread), because
that demon should never keep file systems busy.

The patch is for 2.4.0test1-ac17.

- Werner

---------------------------------- cut here -----------------------------------

--- ref/drivers/char/msp3400.c Tue Jun 13 18:22:53 2000
+++ linux/drivers/char/msp3400.c Tue Jun 13 18:44:12 2000
@@ -679,10 +679,10 @@
 #endif
     
         exit_mm(current);
+ exit_fs(current);
         current->session = 1;
         current->pgrp = 1;
         sigfillset(&current->blocked);
- current->fs->umask = 0;
         strcpy(current->comm,"msp3400");
 
         msp->thread = current;
@@ -931,10 +931,10 @@
 #endif
     
         exit_mm(current);
+ exit_fs(current);
         current->session = 1;
         current->pgrp = 1;
         sigfillset(&current->blocked);
- current->fs->umask = 0;
         strcpy(current->comm,"msp3410 [auto]");
 
         msp->thread = current;

-- 
  _________________________________________________________________________
 / Werner Almesberger, ICA, EPFL, CH       werner.almesberger@ica.epfl.ch /
/_IN_N_032__Tel_+41_21_693_6621__Fax_+41_21_693_6610_____________________/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jun 15 2000 - 21:00:28 EST