[patch-2.4.0-test1-ac17] cc clobber not needed for cpuid

From: Tigran Aivazian (tigran@veritas.com)
Date: Tue Jun 13 2000 - 03:51:29 EST


Hi Alan,

I just checked P3 Volume II and I can't see cpuid changing any of
condition codes (or any other bits) in the EFLAGS. Therefore, the
"cc" clobber directive is not needed when invoking "cpuid" from C.

(Peter Anvin noticed this first but he didn't cc me so I didn't notice
there is this little flaw in Philipp's fix of microcode's recent bug
until now).

Regards,
Tigran

--- arch/i386/kernel/microcode.c.0 Tue Jun 13 09:43:44 2000
+++ arch/i386/kernel/microcode.c Tue Jun 13 09:43:55 2000
@@ -227,7 +227,7 @@
                                 }
 
                                 wrmsr(0x79, (unsigned int)(m->bits), 0);
- __asm__ __volatile__ ("cpuid" : : : "ax", "bx", "cx", "dx", "cc");
+ __asm__ __volatile__ ("cpuid" : : : "ax", "bx", "cx", "dx");
                                 rdmsr(0x8B, val[0], val[1]);
 
                                 req->err = 0;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jun 15 2000 - 21:00:27 EST