This was probably discussed before ... but even if it was, it wasn't fixed.
One example of the problem I am encountering is in fs/Makefile. Note around
line 19. Anyone experienced with diff and patch should instantly notice the
glaring error (okay, maybe it's not _that_ obvious): if you apply more than
one fs patch, it's likely going to botch up that line! diff and patch are
not smart enough to realize that we want the relavant fs subdirectories to
be in a whitespace-delimited list, and that it should just insert the new
stuff wherever appropriate. Alternative suggestion - bloated but nice to
patch:
ALL_SUB_DIRS = # NULL
ALL_SUB_DIRS = $(ALL_SUB_DIRS) ext2
ALL_SUB_DIRS = $(ALL_SUB_DIRS) minix
ALL_SUB_DIRS = $(ALL_SUB_DIRS) fat
...
ALL_SUB_DIRS = $(ALL_SUB_DIRS) reiserfs
ALL_SUB_DIRS = $(ALL_SUB_DIRS) ext3
etc.
Patch attached.
Then the issue will be "fuzz" rather than "reject"... still an issue, but
much lighter on the poor sysadmin working a late night to get a new kernel
up.
I think that this specific instance is something that can be changed without
much trouble (if any) before 2.4.0 -- specifically, no code is changed, and
the Makefile even more obviously does what it's supposed to.
But are there other places in the kernel source where this happens?
Thanks,
Kenneth
--- linux/fs/Makefile.orig Mon Jun 12 22:36:09 2000
+++ linux/fs/Makefile.new Mon Jun 12 22:36:02 2000
@@ -16,10 +16,43 @@
$(BINFMTS) $(FILESYSTEMS)
MOD_LIST_NAME := FS_MODULES
-ALL_SUB_DIRS = coda minix ext2 fat msdos vfat proc isofs nfs umsdos ntfs \
- hpfs sysv smbfs ncpfs ufs efs affs romfs autofs hfs lockd \
- nfsd nls devpts devfs adfs partitions qnx4 udf bfs cramfs \
- openpromfs autofs4 ramfs
+
+ALL_SUB_DIRS =
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) coda
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) minix
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) ext2
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) fat
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) msdos
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) vfat
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) proc
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) isofs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) nfs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) umsdos
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) ntfs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) hpfs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) sysv
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) smbfs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) ncpfs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) ufs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) efs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) affs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) romfs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) autofs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) hfs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) lockd
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) nfsd
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) nls
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) devpts
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) devfs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) adfs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) partitions
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) qnx4
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) udf
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) bfs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) cramfs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) openpromfs
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) autofs4
+ALL_SUB_DIRS = $(ALL_SUB_DIRS) ramfs
SUB_DIRS :=
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Jun 15 2000 - 21:00:27 EST