Re: Serial port patch question

From: David Ford (david@kalifornia.com)
Date: Wed Jun 07 2000 - 14:51:45 EST


_no_ :)

the +/- symbols prefixing the lines show the action to take.

- means delete this line
+ means add this line

If there isn't one of these symbols, then the line is 'context'
information. It shows the patch program what should exist before and after
the modified area.

-d

Richard Rager wrote:

> Ok your patch was
>
> --- linux.old/drivers/char/serial.c Mon Jun 5 06:15:50 2000
> +++ linux/drivers/char/serial.c Mon Jun 5 01:14:22 2000
> @@ -4907,7 +4907,7 @@
> !(check_compatible_id(dev)))
> return 1;
>
> - if (res->next)
> + if (!res || res->next)
> return 1;
>
> for (resa = res->alt; resa; resa = resa->alt) {
>
> -d
>
> Ok does this mean it remove the line for (resa = res->alt; ....
>
> if so then how about the ending { if you remove it the for is unbalence
> or does it do what is below
>
> I try to make a patch and come up with this
>
> --- linux.ac/drivers/char/serial.c Wed Jun 7 11:47:21 2000
> +++ linux.ac-serial/drivers/char/serial.c Wed Jun 7 11:44:56 2000
> @@ -4904,19 +4904,9 @@
> !(check_compatible_id(dev)))
> return 1;
>
> - if (res->next)
> + if (!res || res->next)
> return 1;
>
> - for (resa = res->alt; resa; resa = resa->alt) {
> - struct isapnp_port *port;
> - for (port = res->port; port; port = port->next)
> - if ((port->size == 8) &&
> - ((port->min == 0x2f8) ||
> - (port->min == 0x3f8) ||
> - (port->min == 0x2e8) ||
> - (port->min == 0x3e8)))
> - return 0;
> - }
>
> return 1;
> }
>
> Believe this or not it works for me.
>
> Enjoy,
>
> Richard Rager
> (KB8RLN) to people who know what that is.

--
"The difference between 'involvement' and 'commitment' is like an
eggs-and-ham breakfast: the chicken was 'involved' - the pig was
'committed'."

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jun 07 2000 - 21:00:29 EST