Re: 2.2.16pre{5,7}: loss of SCSI CDROM volume control

From: Matthew Clarke (Matthew_Clarke@mindlink.bc.ca)
Date: Wed Jun 07 2000 - 02:47:09 EST


mardi, le 6 juin, 2000, Jens Axboe nous a dit ceci:

> On Mon, Jun 05 2000, Matthew Clarke wrote:
> > Result is a non-zero return from the first cdrom_mode_sense, which causes
> > an immediate return without doing anything further. Original code lines
> > (reformatted for this e-mail):
> >
> > if ((ret = cdrom_mode_sense(cdi, &cgc, GPMODE_AUDIO_CTL_PAGE, 0)))
> > return ret;
> >
> > New:
> >
> > if ((ret = cdrom_mode_sense(cdi, &cgc, GPMODE_AUDIO_CTL_PAGE, 0)))
> > {
> > printk( "mjcc: cdrom_mode_sense returning %d (0x%x)\n", ret, ret );
> > return ret;
> > }
> >
> > Printk shows up as:
> >
> > mjcc: cdrom_mode_sense returning 671088642 (0x28000002)
> >
> > If anyone wants to look at this before I stumble my way through
> > sr_packet() and SCSI-land, feel free to ask for any more information you
> > need, or to tell me where to go. :)
>
> Could you try and add something like
>
> if (cgc.sense)
> printk("%02x.%02x.%02x\n", cgc.sense->sense_key, cgc.sense->asc, cgc.sense->ascq);
>
> where it fails? Thanks.

Tried this. (With 2.2.16pre8, BTW.) The printk did not trigger. When I
added a printk to print the value of cgc.sense, it was 0x0000000.

Doing a little more digging (read: guesswork,) I made this change to
sr_packet():

        stat = SCpnt->result;

+ printk( "mjcc: sr_packet will return %d (0x%x)\n", stat, stat );
+ if (stat != 0)
+ print_sense( "mjcc", SCpnt );
+
        /* release */

and got the following:

mjcc: sr_packet will return 671088642 (0x28000002)
[valid=0] Info fld=0x0, Current mjcc0b:00: sense key Illegal Request
Additional sense indicates Invalid command operation code
mjcc: cdrom_mode_sense returning 671088642, 0x28000002

Does this help any?

Thanks,
Matt.

-- 
Any research done on how to efficiently use computers has been long lost
in the mad rush to upgrade systems to do things that aren't needed by
people who don't understand what they are really supposed to do with
them.				-- Graham Reed, in a.s.r.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jun 07 2000 - 21:00:27 EST